[PATCH] D72763: [mlir][spirv] Use sybmolize functions in enum attribute predicates

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 06:11:24 PST 2020


antiagainst created this revision.
antiagainst added reviewers: benvanik, denis13.
Herald added subscribers: llvm-commits, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.
antiagainst added a parent revision: D72760: [mlir][spirv] Add implied capabilities and availability for capabilities.

By default, for an enum attribute, we will generate a list of equality
comparisons for all supported cases inside it's predicate. This list
can be fairly large for certain SPIR-V enum attributes. Instead, we
already have such a list generated by EnumsGen in the symbolize
functions. Leverage that to simplify the generated C++ code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72763

Files:
  mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td
  mlir/utils/spirv/gen_spirv_dialect.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72763.238231.patch
Type: text/x-patch
Size: 8078 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200115/bcc53331/attachment.bin>


More information about the llvm-commits mailing list