[PATCH] D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 01:33:00 PST 2020


grimar added a comment.

In D71835#1820317 <https://reviews.llvm.org/D71835#1820317>, @MaskRay wrote:

> In D71835#1818892 <https://reviews.llvm.org/D71835#1818892>, @grimar wrote:
>
> > Assuming we want to keep them, I am thinking about shortening and lower-casing:
> >
> >   0x0000000012345678 (unknown) 0x8765432187654321
> >   0x000000006abcdef0 (OS specific) 0x9988776655443322
> >   0x0000000076543210 (processor specific) 0x5555666677778888
> >
>
>
> This looks good.


OK. Lets wait a day or two more to see if anyone else has comments/ideas/objections about this and I'll post the suggestion to GNU mail list then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71835/new/

https://reviews.llvm.org/D71835





More information about the llvm-commits mailing list