[PATCH] D72744: [NFC] Refactor InlineResult for readability

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 20:37:09 PST 2020


mtrofin added a comment.

In D72744#1820973 <https://reviews.llvm.org/D72744#1820973>, @davidxl wrote:

> Class Name ResultWithMessage sounds too generic. Why not keeping the InlineResult class name? The rest of the changes look reasonable.


Oh, because I read "InlineResult" as result of performing inlining, not also as a result of an inlinability analysis, but maybe I'm overthinking it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72744/new/

https://reviews.llvm.org/D72744





More information about the llvm-commits mailing list