[PATCH] D72745: [MC][test] Fix non-portable GNU diff option

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 17:51:38 PST 2020


hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: daltenty, jasonliu.
Herald added a project: LLVM.

This patch replaces the non-portable GNU diff option `--strip-trailing-cr` with the POSIX `-b` option in two test files.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72745

Files:
  llvm/test/MC/ARM/preserve-comments-arm.s
  llvm/test/MC/AsmParser/preserve-comments.s


Index: llvm/test/MC/AsmParser/preserve-comments.s
===================================================================
--- llvm/test/MC/AsmParser/preserve-comments.s
+++ llvm/test/MC/AsmParser/preserve-comments.s
@@ -1,5 +1,5 @@
 	#RUN: llvm-mc -preserve-comments -n -triple i386-linux-gnu < %s > %t
-	#RUN: diff --strip-trailing-cr %s %t
+	#RUN: diff -b %s %t
 	.text
 
 foo:	#Comment here
Index: llvm/test/MC/ARM/preserve-comments-arm.s
===================================================================
--- llvm/test/MC/ARM/preserve-comments-arm.s
+++ llvm/test/MC/ARM/preserve-comments-arm.s
@@ -1,6 +1,6 @@
 	@RUN: llvm-mc -preserve-comments -n -triple arm-eabi < %s > %t
 	@RUN: sed 's/#[C]omment/@Comment/g' %s > %t2
-	@RUN: diff --strip-trailing-cr %t %t2
+	@RUN: diff -b %t %t2
 	.text
 
 	mov	r0, r0


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72745.238151.patch
Type: text/x-patch
Size: 810 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200115/4821927b/attachment.bin>


More information about the llvm-commits mailing list