[PATCH] D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 11:43:22 PST 2020


sbc100 added a comment.

@ruiu, I tested the ELF linking I an believe it has the same problem.  With ELF it looks like the effect is that bitcode symbols all end up with address 0 in the final binary.  I think its better to fail at link time.. so we should probably port this change, or something like it to ELF.

Sadly its very hard to test this, since it requires knowledge of what the codegen is going to do, and finding a symbol that is not covered in the static libcall list returned by `getRuntimeLibcallSymbols`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71632/new/

https://reviews.llvm.org/D71632





More information about the llvm-commits mailing list