[PATCH] D72654: [SVE] Add patterns for MUL immediate instruction.

Danilo Carvalho Grael via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 10:44:46 PST 2020


dancgr marked 2 inline comments as done.
dancgr added a comment.

In D72654#1818201 <https://reviews.llvm.org/D72654#1818201>, @efriedma wrote:

> Do we have any negative tests, for immediates that are outside the range of the sve mul immediate instruction?


No, I will add some negative tests for immediates that are out of range.



================
Comment at: llvm/test/CodeGen/AArch64/sve-int-arith-imm.ll:384
+; CHECK-NEXT: ret
+ %elt = insertelement <vscale x 16 x i8> undef, i8 105, i32 0
+  %splat = shufflevector <vscale x 16 x i8> %elt, <vscale x 16 x i8> undef, <vscale x 16 x i32> zeroinitializer
----------------
c-rhodes wrote:
> nit: space (and below)
Will fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72654/new/

https://reviews.llvm.org/D72654





More information about the llvm-commits mailing list