[PATCH] D72469: SCC: Allow ReplaceNode to safely support insertion

[Warren Ristow via Phabricator via llvm-commits]

wristow added a comment.

In D72469#1819623 <https://reviews.llvm.org/D72469#1819623>, @probinson wrote:

> Seems to me we've needed to do this sort of tweak before, so LGTM.
>  Because it depends on the memory-management behavior of the map, it would be tricky to test with IR input.  Would it be feasible to do something in llvm/unittests/ADT/SCCIteratorTest.cpp that could trigger this reliably?  Can be done as a follow-up, as I know the branch is coming soon.


Thanks for that @probinson.  I'll look into the unittest approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72469/new/

https://reviews.llvm.org/D72469