[PATCH] D72522: [Hexagon] Add support for general dynamic relocs

Sid Manning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 09:55:12 PST 2020


sidneym updated this revision to Diff 237991.
sidneym retitled this revision from "[Hexagon] Add support for global dynamic relocs" to "[Hexagon] Add support for general dynamic relocs".
sidneym added a comment.

Update testcase.

- Verify the absence of relocations in the executable.
- hexagon may call tls_get_addr but the name is not explicitly stated in the ABI.  The internally maintained linker will create the symbol to call which is generally "__tls_get_addr".  There are instances when it would not be "__tls_get_addr" such as when a user built a static executable using objects built -shared -pic.  In such a case the internal linker would create a stub called __hexagon_ie_tls_get_addr and call it.  LLD for hexagon would not support doing this until some design could be agreed upon.
- Don't check explicit addresses in GOT.
- Added the check for the closing brace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72522/new/

https://reviews.llvm.org/D72522

Files:
  lld/ELF/Arch/Hexagon.cpp
  lld/test/ELF/hexagon-tls-gd.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72522.237991.patch
Type: text/x-patch
Size: 3525 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200114/cdded2dc/attachment.bin>


More information about the llvm-commits mailing list