[PATCH] D72710: [InstCombine] Let combineLoadToNewType preserve ABI alignment of the load (PR44543)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 09:36:41 PST 2020


lebedev.ri added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/load-bitcast64.ll:3
 
-target datalayout = "p:64:64:64"
+target datalayout = "p:64:64:64-i64:32:32"
 
----------------
aqjune wrote:
> aqjune wrote:
> > lebedev.ri wrote:
> > > Please precommit the test changes first, and please use the script to autogenerate check lines
> > Ok, I'll make a separate commit for this.
> Or do you prefer having the auto generated check in this patch?
First, change the datalayout and autogenerate the check lines here, and commit that.
Then, rebase this patch to only show the changes caused by the fix itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72710/new/

https://reviews.llvm.org/D72710





More information about the llvm-commits mailing list