[PATCH] D72469: SCC: Allow ReplaceNode to safely support insertion

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 07:24:47 PST 2020


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

Seems to me we've needed to do this sort of tweak before, so LGTM.
Because it depends on the memory-management behavior of the map, it would be tricky to test with IR input.  Would it be feasible to do something in llvm/unittests/ADT/SCCIteratorTest.cpp that could trigger this reliably?  Can be done as a follow-up, as I know the branch is coming soon.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72469/new/

https://reviews.llvm.org/D72469





More information about the llvm-commits mailing list