[PATCH] D72693: [TableGen] Update editor modes for new keywords.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 05:07:33 PST 2020


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LG in principle.



================
Comment at: llvm/utils/kate/llvm-tablegen.xml:11
+      <item> else </item>
+      <item> defvar </item>
     </list>
----------------
simon_tatham wrote:
> lebedev.ri wrote:
> > I think `defvar` should go next to `def`
> That would mean putting it in the 'class-like' section, which I thought probably wasn't right, on the grounds that `defvar` does not open a block with further declarations inside it, whereas `def` does, in common with the other 'class-like' keywords.
> 
> I admit I'm not a Kate user, though, so I don't know what difference (if any) that would actually make during editing.
On a second thought, `let` seems like a closer fit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72693/new/

https://reviews.llvm.org/D72693





More information about the llvm-commits mailing list