[PATCH] D71931: [DWARF] Allow empty address range tables.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 03:15:44 PST 2020


ikudrin marked 2 inline comments as done.
ikudrin added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugArangeSet.cpp:93
       else
-        break; // We are done if we get a zero address and length
+        return true; // We are done if we get a zero address and length
     }
----------------
aprantl wrote:
> FYI, the LLVM coding style prefers putting the comment on a line of its own before the statement.
I am unable to find such a recommendation in https://llvm.org/docs/CodingStandards.html. Could you point that out?

Anyway, these lines are temporary and are going to be removed in the next patch of the stack, D71875.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71931/new/

https://reviews.llvm.org/D71931





More information about the llvm-commits mailing list