[PATCH] D72629: [ARM][MVE] Disallow VPSEL for tail predication

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 01:42:17 PST 2020


samparker added a comment.

> Does VPNOT not need to be explicitly excluded because they are def's anyway?

It's actually the multiple vpr uses which prevent them from being included. I think I'll explicitly disallow them for now, as well as adding the comment.

> Can you add a quick comment to each that says what it's trying to test? And maybe if the MIR is modified. inloop-vpsel-1.mir and inloop-vpsel-3.mir seem to be the same.

That they do! I will add comments and fix the test.

> This wasn't code-gen'd right? I don't think VPNOT of VPSEL should end up inside a VPT block at present.

No, I just saw that I could predicate it so might as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72629/new/

https://reviews.llvm.org/D72629





More information about the llvm-commits mailing list