[PATCH] D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:710
 
+void writeFileName(raw_ostream &S, const std::string &ArchiveName,
+                   const std::string &ArchitectureName) {
----------------
grimar wrote:
> I think this either could accept Twines:
> 
> `writeFileName(raw_ostream &S, const Twine ArchiveName, ...`
> 
> or I am thinking it could probably be:
> 
> `std::string getFileName(const Twine ArchiveName, ...)`
> 
> I think in the latter case the callers code can be a bit nicer/simpler probably.
> 
`const Twine` -> `const Twine &`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72658/new/

https://reviews.llvm.org/D72658