[PATCH] D72659: [xray] Add xray-ignore-loops option

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 17:36:48 PST 2020


smeenai resigned from this revision.
smeenai added a comment.

To make sure I'm understanding this correctly, previously, for any function with a loop in it, XRay would ignore the minimum instruction count threshold and instrument it unconditionally. You're adding an option to make XRay respect the threshold even if the function has loops. Is that correct?

I'm wondering what the reason is for the existing logic ignoring loops, and if we can incorporate loops into the existing logic instead of adding another option (and whether that would be better). I'm sure @dberris can speak more to that, so leaving this to him.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72659/new/

https://reviews.llvm.org/D72659





More information about the llvm-commits mailing list