[PATCH] D72649: [PowerPC][NFC] Reclaim TSFlags bit 6

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 14:21:09 PST 2020


jsji created this revision.
jsji added reviewers: PowerPC, hfinkel, nemanjai, stefanp, Yi-Hong.Lyu.
Herald added subscribers: llvm-commits, shchenz, kbarton, hiraditya.
Herald added a project: LLVM.
jsji added a project: PowerPC.
Herald added a subscriber: wuzish.

We removed UseVSXReg flag in https://reviews.llvm.org/D58685
But we did not reclain the bit 6 it was assigned,
this will become confusing and a hole later..
We should reclaim it as early as possible before new bits.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72649

Files:
  llvm/lib/Target/PowerPC/PPCInstrFormats.td
  llvm/lib/Target/PowerPC/PPCInstrInfo.h


Index: llvm/lib/Target/PowerPC/PPCInstrInfo.h
===================================================================
--- llvm/lib/Target/PowerPC/PPCInstrInfo.h
+++ llvm/lib/Target/PowerPC/PPCInstrInfo.h
@@ -65,7 +65,7 @@
   NewDef_Shift = 6,
 
   /// This instruction is an X-Form memory operation.
-  XFormMemOp = 0x1 << (NewDef_Shift+1)
+  XFormMemOp = 0x1 << NewDef_Shift
 };
 } // end namespace PPCII
 
Index: llvm/lib/Target/PowerPC/PPCInstrFormats.td
===================================================================
--- llvm/lib/Target/PowerPC/PPCInstrFormats.td
+++ llvm/lib/Target/PowerPC/PPCInstrFormats.td
@@ -39,7 +39,7 @@
 
   // Indicate that this instruction is of type X-Form Load or Store
   bits<1> XFormMemOp = 0;
-  let TSFlags{7}  = XFormMemOp;
+  let TSFlags{6}  = XFormMemOp;
 
   // Fields used for relation models.
   string BaseName = "";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72649.237779.patch
Type: text/x-patch
Size: 864 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200113/1f387295/attachment.bin>


More information about the llvm-commits mailing list