[PATCH] D72616: [AMDGPU] Remove duplicate gfx10 assembler and disassembler tests

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Here's the disassembler diff with a bit more context:

  diff --git a/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt b/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt
  index c1ec51ee7ad..3e040460988 100644
  --- a/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt
  +++ b/llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt
  @@ -5773,17 +5773,14 @@
   
   # GFX10: ds_read_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0x05]
   0xff 0xff 0xc4 0xda 0x00 0x00 0x00 0x05
   
   # GFX10: ds_read_addtid_b32 v5 offset:65535 gds ; encoding: [0xff,0xff,0xc6,0xda,0x00,0x00,0x00,0x05]
   0xff 0xff 0xc6 0xda 0x00 0x00 0x00 0x05
   
  -# GFX10: ds_read_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc4,0xda,0x00,0x00,0x00,0x05]
  -0xff 0xff 0xc4 0xda 0x00 0x00 0x00 0x05
  -
   # GFX10: ds_read_b128 v[252:255], v1 offset:65535 ; encoding: [0xff,0xff,0xfc,0xdb,0x01,0x00,0x00,0xfc]
   0xff,0xff,0xfc,0xdb,0x01,0x00,0x00,0xfc
   
   # GFX10: ds_read_b128 v[5:8], v1         ; encoding: [0x00,0x00,0xfc,0xdb,0x01,0x00,0x00,0x05]
   0x00,0x00,0xfc,0xdb,0x01,0x00,0x00,0x05
   
   # GFX10: ds_read_b128 v[5:8], v1 offset:4 ; encoding: [0x04,0x00,0xfc,0xdb,0x01,0x00,0x00,0x05]
  @@ -7081,17 +7078,14 @@
   
   # GFX10: ds_write_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0x00,0x05,0x00,0x00]
   0xff 0xff 0xc0 0xda 0x00 0x05 0x00 0x00
   
   # GFX10: ds_write_addtid_b32 v5 offset:65535 gds ; encoding: [0xff,0xff,0xc2,0xda,0x00,0x05,0x00,0x00]
   0xff 0xff 0xc2 0xda 0x00 0x05 0x00 0x00
   
  -# GFX10: ds_write_addtid_b32 v5 offset:65535 ; encoding: [0xff,0xff,0xc0,0xda,0x00,0x05,0x00,0x00]
  -0xff 0xff 0xc0 0xda 0x00 0x05 0x00 0x00
  -
   # GFX10: ds_write_b128 v1, v[252:255] offset:65535 ; encoding: [0xff,0xff,0x7c,0xdb,0x01,0xfc,0x00,0x00]
   0xff,0xff,0x7c,0xdb,0x01,0xfc,0x00,0x00
   
   # GFX10: ds_write_b128 v1, v[2:5]        ; encoding: [0x00,0x00,0x7c,0xdb,0x01,0x02,0x00,0x00]
   0x00,0x00,0x7c,0xdb,0x01,0x02,0x00,0x00
   
   # GFX10: ds_write_b128 v1, v[2:5] offset:4 ; encoding: [0x04,0x00,0x7c,0xdb,0x01,0x02,0x00,0x00]

You can see that the cases I removed are duplicates of the one-before-last.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72616/new/

https://reviews.llvm.org/D72616