[PATCH] D72454: [AIX] Enable frame pointer for AIX and add related test suite

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-alloca.ll:2
+; RUN: llc < %s -mtriple=powerpc-unknown-linux-gnu | FileCheck %s -check-prefix=PPC32-LINUX
+; RUN: llc < %s -mtriple=powerpc64-unknown-linux-gnu | FileCheck %s -check-prefix=PPC64-LINUX
+; RUN: llc < %s -mtriple=powerpc-unknown-linux-gnu -frame-pointer=all | FileCheck %s -check-prefix=PPC32-LINUX
----------------
Xiangling_L wrote:
> ZarkoCA wrote:
> > Is this testing the 64-bit ELFV1 ABI or the 64-bit ELFV2 ABI? Basically I'm asking whether this should be `powerpc64le-unknown-linux-gnu` or is this ok? 
> The default ABI for 64bit BE on Linux platform is ELFV1 ABI, the which AIX ABI is similar to. So it should be fine to leave it as it is.
Thanks for the explanation. 


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-alloca.ll:39
+; - Frame pointer register (r31) is saved/defined/restored.
+; - Allocated area is referrd by frame pointer with correct offset.
+; - Allocated area is 4 bytes aligned in the case of int.
----------------
Xiangling_L wrote:
> ZarkoCA wrote:
> > typo: should be `referred`, this happens in other test cases below
> Thanks. updated it.
Sorry, I wasn't clear the same typo happens in the other test case files and not only in this one.  I've marked the typos I caught. 


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-large.ll:26
+;   elimination is disabled.
+; - Allocated area is referrd by stack pointer with correct offset.
+; - Allocated area is 4 bytes aligned in the case of int.
----------------
s/referrd/referred/


================
Comment at: llvm/test/CodeGen/PowerPC/aix-frames-alloc-char.ll:18
+;   elimination is disabled.
+; - Allocated area is referrd by frame pointer with correct offset.
+; - Allocated area is 16 bytes aligned in the case of char.
----------------
s/referrd/referred/


================
Comment at: llvm/test/CodeGen/PowerPC/aix-frames-alloca-with-func-call.ll:19
+; - Frame pointer register (r31) is saved/defined/restored.
+; - Allocated area and parameter save area are referrd by stack pointer with
+;   correct offset, while local variable space is referred by frame pointer
----------------
s/referrd/referred/


================
Comment at: llvm/test/CodeGen/PowerPC/aix-frames-alloca-with-func-call.ll:26
+
+define dso_local signext i32 @foo(i32 %n) #0 {
+entry:
----------------
Can the `#0` be removed? 


================
Comment at: llvm/test/CodeGen/PowerPC/aix-frames-dyn-multi-alloc.ll:17
+; - Frame pointer register (r31) is saved/defined/restored.
+; - Allocated area is referrd by stack pointer with correct offset.
+; - Allocated area is 4 bytes aligned in the case of int.
----------------
s/referrd/reffered/


================
Comment at: llvm/test/CodeGen/PowerPC/aix-frames-small.ll:20
+;   elimination is disabled.
+; - Allocated area is referrd by stack pointer with correct offset.
+; - Allocated area is 4 bytes aligned in the case of int.
----------------
s/referrd/referred/


================
Comment at: llvm/test/CodeGen/PowerPC/aix32-frames-stack-floor.ll:10
+;   elimination is disabled.
+; - Allocated area is referrd by stack pointer with correct offset.
+; - Allocated area is 4 bytes aligned in the case of int.
----------------
s/referrd/referred/


================
Comment at: llvm/test/CodeGen/PowerPC/aix64-frames-stack-floor.ll:10
+;   elimination is disabled.
+; - Allocated area is referrd by stack pointer with correct offset.
+; - Allocated area is 4 bytes aligned in the case of int.
----------------
s/referrd/referred/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72454/new/

https://reviews.llvm.org/D72454