[PATCH] D72336: [mlir] Create a gpu.module operation for the GPU Dialect.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp:188-191
+    gpu::GPUModuleOp::build(&builder, state, kernelFunc.getName());
+    auto kernelModule = cast<gpu::GPUModuleOp>(Operation::create(state));
     SymbolTable symbolTable(kernelModule);
     symbolTable.insert(kernelFunc);
----------------
herhut wrote:
> Maybe SymbolTable should also provide a create<T> abstraction to hide these details of construction an operation. Not for this change, though.
That would be fine to add in a followup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72336/new/

https://reviews.llvm.org/D72336