[PATCH] D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h:36
     explicit Range(uint64_t LowPC = -1ULL, uint64_t HighPC = -1ULL,
-                   uint32_t CUOffset = -1U)
+                   uint64_t CUOffset = -1U)
       : LowPC(LowPC), Length(HighPC - LowPC), CUOffset(CUOffset) {}
----------------
-1ULL? But really, these should be optionals, right?


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h:56
 
     uint64_t LowPC; /// Start of address range.
+    uint64_t Length; /// End of address range (not including this address).
----------------
Either:

```
/// Start of address range.
uint64_t LowPC; 
```

or

```
uint64_t LowPC; ///< Start of address range.
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71834/new/

https://reviews.llvm.org/D71834