[PATCH] D72580: [mlir][Linalg] Update ReshapeOp::build to be more idiomatic

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 07:16:16 PST 2020


ftynse accepted this revision.
ftynse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/test/EDSC/builder-api-test.cpp:986
+  linalg_reshape(memrefType, reshaped,
+                 ArrayRef<ArrayRef<AffineExpr>>{{i, j}, k});
+
----------------
Can we have an AffineExpr with symbols here? Just to check that symbol removal machinery works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72580/new/

https://reviews.llvm.org/D72580





More information about the llvm-commits mailing list