[PATCH] D72572: [PowerPC][Future] Branch Distance Estimation For Prefixed Instructions

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

Aside from a couple of minor nits, LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCBranchSelector.cpp:161
+        // The if statement checks to make sure that two 8 byte instructions
+        // are at least 64 bytes away from each other. You cannot have two
+        // instructions that both need alignment that are within 64 bytes of
----------------
s/You cannot have/It is not possible for


================
Comment at: llvm/test/CodeGen/PowerPC/alignlongjumptest.mir:2
+# RUN: llc -mcpu=future -mtriple=powerpc64le-unknown-unknown %s \
+# RUN:   -start-before=ppc-branch-select -verify-machineinstrs -filetype=obj -o - | \
+# RUN:   llvm-objdump -mcpu=future -d -r - | FileCheck --check-prefix=CHECK-LE %s
----------------
Minor nit: since you are splitting the run directives across multiple lines, might as well keep them to 80 columns. It appears that this is a bit wider.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72572/new/

https://reviews.llvm.org/D72572