[PATCH] D72611: [AMDGPU] Improve error checking in gfx10 assembler tests

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 05:48:23 PST 2020


foad created this revision.
foad added reviewers: rampitec, arsenm.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

This adds checks that the expected error was actually reported against
the correct instruction, and fixes a couple of problems that that showed
up: one incorrect W32 <https://reviews.llvm.org/W32>-ERR:

v_cmp_class_f16_sdwa vcc, v1, v2 src0_sel:DWORD src1_sel:DWORD
 // W64 <https://reviews.llvm.org/W64>: encoding: [0xf9,0x04,0x1e,0x7d,0x01,0x00,0x06,0x06]
-// W32 <https://reviews.llvm.org/W32>-ERR: error: invalid operand for instruction
+// W32 <https://reviews.llvm.org/W32>-ERR: error: {{instruction not supported on this GPU|invalid operand for instruction}}

and one missing W32 <https://reviews.llvm.org/W32>-ERR:

v_cmp_class_f16_sdwa s[6:7], v1, v2 src0_sel:DWORD src1_sel:DWORD
 // W64 <https://reviews.llvm.org/W64>: encoding: [0xf9,0x04,0x1e,0x7d,0x01,0x86,0x06,0x06]
+// W32 <https://reviews.llvm.org/W32>-ERR: error: invalid operand for instruction


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72611

Files:
  llvm/test/MC/AMDGPU/gfx10_asm_all.s





More information about the llvm-commits mailing list