[PATCH] D72599: GlobalISel: Preserve load/store metadata in IRTranslator

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 05:20:24 PST 2020


arsenm created this revision.
arsenm added reviewers: aemerson, aditya_nandakumar, paquette, dsanders.
Herald added subscribers: Petar.Avramovic, volkan, jfb, atanasyan, hiraditya, rovka, nhaehnle, wdng, jvesely, sdardis.
Herald added a project: LLVM.

This was dropping the invariant metadata on dead argument loads, so
they weren't deleted.

Atomics still need to be fixed the same way. Also, apparently store
was never preserving dereferencable which should also be fixed.


https://reviews.llvm.org/D72599

Files:
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/TargetLoweringBase.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
  llvm/lib/Target/SystemZ/SystemZISelLowering.h
  llvm/lib/Target/XCore/XCoreISelLowering.cpp
  llvm/lib/Target/XCore/XCoreISelLowering.h
  llvm/test/CodeGen/AArch64/GlobalISel/constant-dbg-loc.ll
  llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-load-metadata.ll
  llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-stackprotect-check.ll
  llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-store-metadata.ll
  llvm/test/CodeGen/AArch64/GlobalISel/localizer-arm64-tti.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-function-args.ll
  llvm/test/CodeGen/Mips/GlobalISel/irtranslator/var_arg.ll
  llvm/test/CodeGen/X86/GlobalISel/x86_64-irtranslator-struct-return.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72599.237632.patch
Type: text/x-patch
Size: 35101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200113/cdb4e196/attachment-0001.bin>


More information about the llvm-commits mailing list