[llvm] 7f1cf7d - [X86] Fix MSVC "truncation from 'int' to 'bool'" warning. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 03:09:02 PST 2020


Author: Simon Pilgrim
Date: 2020-01-13T11:08:12Z
New Revision: 7f1cf7d5f658b15abb8bd6840fc01e6d44487a23

URL: https://github.com/llvm/llvm-project/commit/7f1cf7d5f658b15abb8bd6840fc01e6d44487a23
DIFF: https://github.com/llvm/llvm-project/commit/7f1cf7d5f658b15abb8bd6840fc01e6d44487a23.diff

LOG: [X86] Fix MSVC "truncation from 'int' to 'bool'" warning. NFCI.

Added: 
    

Modified: 
    llvm/lib/Target/X86/Disassembler/X86Disassembler.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/Disassembler/X86Disassembler.cpp b/llvm/lib/Target/X86/Disassembler/X86Disassembler.cpp
index fb89b2cb90fe..8d0c12e94643 100644
--- a/llvm/lib/Target/X86/Disassembler/X86Disassembler.cpp
+++ b/llvm/lib/Target/X86/Disassembler/X86Disassembler.cpp
@@ -936,14 +936,14 @@ static bool readOpcode(struct InternalInstruction *insn) {
       LLVM_DEBUG(dbgs() << format("Found a three-byte escape prefix (0x%hhx)",
                                   current));
       if (consume(insn, current))
-        return -1;
+        return true;
 
       insn->opcodeType = THREEBYTE_38;
     } else if (current == 0x3a) {
       LLVM_DEBUG(dbgs() << format("Found a three-byte escape prefix (0x%hhx)",
                                   current));
       if (consume(insn, current))
-        return -1;
+        return true;
 
       insn->opcodeType = THREEBYTE_3A;
     } else if (current == 0x0f) {


        


More information about the llvm-commits mailing list