[PATCH] D72451: [ARM][MVE] Enable extending gathers

Anna Welker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 02:16:29 PST 2020


anwel added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:140
+    if (OriginalTy->getVectorNumElements() == 4)
+      ResultTy = VectorType::get(OriginalTy->getInt32Ty(C), 4);
+    else if (OriginalTy->getVectorNumElements() == 8)
----------------
dmgreen wrote:
> Should this be Type::getInt32Ty ? Or Builder.getInt32() ?
I assume `Type::getInt32Ty(C)` is the cleanest. I'll use that instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72451/new/

https://reviews.llvm.org/D72451





More information about the llvm-commits mailing list