[PATCH] D72225: Align branches within 32-Byte boundary(Prefix padding)
LuoYuanke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 01:02:20 PST 2020
LuoYuanke added inline comments.
================
Comment at: llvm/lib/MC/MCAssembler.cpp:616
+ for (uint64_t i = 0; i != FragmentSize; ++i)
+ OS << char(BF.getValue());
+ }
----------------
Why we declare Value as int64_t in MCAlignFragment? It seems only 1 byte is needed. Or we add assert(BF.getValueSize() == 1)?
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:532
+ PF->setAlignment(AlignBoundary);
+ PF->setEmitNops(true);
+ return;
----------------
Just to confirm that there is no MCBoundaryAlignFragment between the 2 macro fusion instructions. Right?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72225/new/
https://reviews.llvm.org/D72225
More information about the llvm-commits
mailing list