[llvm] 07028b5 - [SCEV] Follow up of D71563: addressing post commit comment. NFC.

Sjoerd Meijer via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 00:58:24 PST 2020


Author: Sjoerd Meijer
Date: 2020-01-13T08:54:38Z
New Revision: 07028b5a87803a3a857d6dd6320a0f7de4db23ad

URL: https://github.com/llvm/llvm-project/commit/07028b5a87803a3a857d6dd6320a0f7de4db23ad
DIFF: https://github.com/llvm/llvm-project/commit/07028b5a87803a3a857d6dd6320a0f7de4db23ad.diff

LOG: [SCEV] Follow up of D71563: addressing post commit comment. NFC.

Added: 
    

Modified: 
    llvm/lib/Analysis/ScalarEvolution.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp
index 648412a63a0e..26a9a5ddf1ea 100644
--- a/llvm/lib/Analysis/ScalarEvolution.cpp
+++ b/llvm/lib/Analysis/ScalarEvolution.cpp
@@ -4507,17 +4507,6 @@ static Optional<BinaryOp> MatchBinaryOp(Value *V, DominatorTree &DT) {
   if (!Op)
     return None;
 
-  // Recognise intrinsic loop.decrement.reg, and as this has exactly the same
-  // semantics as a Sub, return a binary sub expression.
-  if (auto *II = dyn_cast<IntrinsicInst>(V)) {
-    switch (II->getIntrinsicID()) {
-    case Intrinsic::loop_decrement_reg:
-      return BinaryOp(Instruction::Sub, II->getOperand(0), II->getOperand(1));
-    default:
-      return None;
-    }
-  }
-
   // Implementation detail: all the cleverness here should happen without
   // creating new SCEV expressions -- our caller knowns tricks to avoid creating
   // SCEV expressions when possible, and we should not break that.
@@ -4586,6 +4575,12 @@ static Optional<BinaryOp> MatchBinaryOp(Value *V, DominatorTree &DT) {
     break;
   }
 
+  // Recognise intrinsic loop.decrement.reg, and as this has exactly the same
+  // semantics as a Sub, return a binary sub expression.
+  if (auto *II = dyn_cast<IntrinsicInst>(V))
+    if (II->getIntrinsicID() == Intrinsic::loop_decrement_reg)
+      return BinaryOp(Instruction::Sub, II->getOperand(0), II->getOperand(1));
+
   return None;
 }
 


        


More information about the llvm-commits mailing list