[PATCH] D72554: [mlir] support building with BUILD_SHARED_LIBS=ON

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D72554#1816121 <https://reviews.llvm.org/D72554#1816121>, @mehdi_amini wrote:

> > Currently, MLIR itself cannot be compiled as a shared library because of the cyclic dependency among MLIR components.
>
> Can we fix the cyclic dependency to begin with?
>
> It seems like this patch is trying to dance around the underlying issue without addressing it.


Personally, I think it is cleaner to fix the shared library dependence, although I, too have taken the short route to enabling explicit STATIC libraries which can have circular dependencies.
I think that there is not a strong reason for the moment to have add_mlir_library, which is mostly a copy of the corresponding code from add_llvm_library.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72554/new/

https://reviews.llvm.org/D72554