[PATCH] D72582: [X86] Don't inherit 32-bit calling conventions in 64-bit mode.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 12 23:20:50 PST 2020


craig.topper created this revision.
craig.topper added reviewers: spatel, RKSimon, rnk.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Mainly this stops weird thing like v3f64 vectors getting split
into 3 pieces and then using XMM0/XMM1 for the first two, then
finding the f64 in the 32-bit mode and using FP0 next. Now we'll
fail CanLowerReturn and fall back to sret lowering instead.

I had to copy a few lines for mmx since we were dependent on
those being inherited. But I'm not sure tye make sense.
Clang doesn't generate x86_mmx type as a function argument or
return value. So it probably doesn't matter in practice.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72582

Files:
  llvm/lib/Target/X86/X86CallingConv.td
  llvm/test/CodeGen/X86/pr11334.ll
  llvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll
  llvm/test/CodeGen/X86/vectorcall.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72582.237579.patch
Type: text/x-patch
Size: 45522 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200113/00c1098b/attachment.bin>


More information about the llvm-commits mailing list