[PATCH] D72044: [mlir] Add support for attaching a visibility to symbols.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 12 15:29:40 PST 2020


mehdi_amini accepted this revision.
mehdi_amini added inline comments.
This revision is now accepted and ready to land.
Herald added subscribers: liufengdb, aartbik.


================
Comment at: mlir/lib/IR/Module.cpp:85
   // Check that none of the attributes are non-dialect attributes, except for
   // the symbol name attribute.
   for (auto attr : getOperation()->getAttrList().getAttrs()) {
----------------
Can you update the comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72044/new/

https://reviews.llvm.org/D72044





More information about the llvm-commits mailing list