[PATCH] D72487: [AMDGPU] Fix bundle scheduling

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D72487#1813828 <https://reviews.llvm.org/D72487#1813828>, @foad wrote:

> Instead how about doing this and implementing it in `adjustSchedDependency` for AMDGPU?
>
>   diff --git a/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp b/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp
>   index 96a1f86c3e0..ef5926e4f8f 100644
>   --- a/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp
>   +++ b/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp
>   @@ -269,9 +269,9 @@ void ScheduleDAGInstrs::addPhysRegDataDeps(SUnit *SU, unsigned OperIdx) {
>          if (!ImplicitPseudoDef && !ImplicitPseudoUse) {
>            Dep.setLatency(SchedModel.computeOperandLatency(SU->getInstr(), OperIdx,
>                                                            RegUse, UseOp));
>   -        ST.adjustSchedDependency(SU, UseSU, Dep);
>          } else
>            Dep.setLatency(0);
>   +      ST.adjustSchedDependency(SU, UseSU, Dep);
>   
>          UseSU->addPred(Dep);
>        }
>


Looks like this patch would break some internal logic inside Hexagon's adjustSchedDependency()...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72487/new/

https://reviews.llvm.org/D72487