[PATCH] D60389: FileCheck [9/12]: Add support for matching formats

[Alexander Richardson via Phabricator via llvm-commits]

arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.

In D60389#1810018 <https://reviews.llvm.org/D60389#1810018>, @thopre wrote:

> Is everybody happy with the constness changes to the ExpressionFormat operators and the new unit tests?


Looks fine to me. I would say say this can be committed if @jhenderson is happy with it and all tests pass. If there are any remaining issues those can always be fixed in follow-up commit.



================
Comment at: llvm/lib/Support/FileCheckImpl.h:71
+
+  bool operator==(const Kind OtherValue) const { return Value == OtherValue; }
+
----------------
Since `Kind` is just an enum, the const is unnecessary for by-value arguments but I don't think it does any harm either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60389/new/

https://reviews.llvm.org/D60389