[PATCH] D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed.

Sat Jan 11 16:42:29 PST 2020

beanz added a comment.

In D72278#1806013 <https://reviews.llvm.org/D72278#1806013>, @DavidSpickett wrote:

> I found this running lit tests on a Mac that doesn't have sysctl available. Not very familiar with it so I'm not sure why that is the case for our particular machine.
>
> So this change is me assuming the intention was to just print and carry on if "sysctl" fails.

I would be excessively concerned about why a Mac doesn't have `sysctl` available. I'm not actually sure we should continue running tests if it is missing. `sysctl` is a fundamental unix tool that ships with macOS, for it to be missing your OS install is likely broken. If the command is failing (but not missing) that may be masking a different issue. Sandboxing or user permissions can limit which keys sysctl can interrogate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72278/new/

https://reviews.llvm.org/D72278