[PATCH] D72559: [mlir] Add trait for staging update of broadcastable trait

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 11 10:28:16 PST 2020


mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/IR/OpBase.td:1333
+def Broadcastable :
+  NativeOpTrait<"BroadcastableTwoOperandsOneResultWithSameElementType">;
+// Op supports operand broadcast behavior.
----------------
To me `Broadcastable` implying element type seem fairly intuitive, have you looked into introducing a "BroadcastableDimensions" instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72559/new/

https://reviews.llvm.org/D72559





More information about the llvm-commits mailing list