[PATCH] D72436: [SCEV] get a more accurate range for AddRecExpr with nsw flag

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 11 01:46:42 PST 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:5704
+                                       getSignedRangeMax(AddRec->getStart()) +
+                                           1),
+            RangeType);
----------------
This looks a bit ugly, it might make sense to insert a newline after `getNonEmpty(` instead and only do the 4-space indent, so there's still space for the `+ 1`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72436/new/

https://reviews.llvm.org/D72436





More information about the llvm-commits mailing list