[PATCH] D72481: [mlir][EDSC] Refactor dependencies involving EDSCs.

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 09:43:25 PST 2020


jpienaar marked an inline comment as done.
jpienaar added a comment.

This is mostly a mechanical move or is there anything new to look at, correct?

It seems a clang-format of the diff is needed.



================
Comment at: mlir/lib/Dialect/Linalg/EDSC/Builders.cpp:53-54
+    fun();
+  exit();
+  return ValueHandle::null();
+}
----------------
[for follow up] I read exit and was thinking std::exit here. Could we do exitBlock maybe? That way its clearer locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72481/new/

https://reviews.llvm.org/D72481





More information about the llvm-commits mailing list