[PATCH] D72420: [LoopRotate] Add support for rotating loops with switch exit

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 09:23:33 PST 2020


nikic marked 3 inline comments as done.
nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp:283
         if (Options.PreserveLCSSA) {
-          createPHIsForSplitLoopExit(TIBB, NewBB, DestBB);
+          SmallVector<BasicBlock *, 1> Preds(NumEdges, TIBB);
+          createPHIsForSplitLoopExit(Preds, NewBB, DestBB);
----------------
efriedma wrote:
> I'm surprised nobody else has run into this.
Probably this is the first time PreserveLCSSA + MergeIdenticalEdges are used together.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72420/new/

https://reviews.llvm.org/D72420





More information about the llvm-commits mailing list