[PATCH] D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours

Tom Weaver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 08:43:57 PST 2020


TWeaver created this revision.
TWeaver added reviewers: aprantl, dblaikie, djokov, vsk.
TWeaver added a project: debug-info.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Within in this patch are 22 distinct test cases that exercise specific behaviours within the livedebug values pass.

After all the work that's been ongoing with the livedebugvalues pass its become clear that coverage for the expected behaviour was previously lacking.

Rather than risk there not being coverage for said cases I felt it was time to get them added to reduce the risk of a regression in the future.

The aim is to cover behaviour for a standard case with no moves or clobbers, cases with clobbers and cases with moves.

A mix of sequential, loop and diamond control flows are considered in the flavours described above.

happy reviewing.


https://reviews.llvm.org/D72515

Files:
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond_match_clobber.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond_match_move.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond_one_clobber.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond_one_move.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_loop.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_bb_to_bb.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_bb_to_bb_clobbered.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_bb_to_bb_move_to_clobber.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_break.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_break_clobbered.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_clobbered.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_diamond.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_diamond_clobber.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_diamond_move.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_early_clobber.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_two_backedge.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_two_backedge_clobbered.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_within_loop.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_within_loop_clobbered.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_within_loop_moved.mir
  llvm/test/DebugInfo/MIR/X86/livedebugvalues_loop_within_loop_outer_moved.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72515.237336.patch
Type: text/x-patch
Size: 70384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200110/a8bbbfd3/attachment.bin>


More information about the llvm-commits mailing list