[PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

Fri Jan 10 04:10:19 PST 2020

jhenderson added a comment.

In D72158#1813369 <https://reviews.llvm.org/D72158#1813369>, @dblaikie wrote:

> As mentioned in another review - I'm not sure "assume bigger is correct" is a great strategy & not sure there's a lot of value in continuing in the face of a conflict like that. What sort of situations really benefit from such parsing optimism?

See my comments in D72155 <https://reviews.llvm.org/D72155>. Having discussed it with a colleague, I think going with "the length field is always right" is a better approach, where possible. The extra parsing could be useful to some users, I guess.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72158/new/

https://reviews.llvm.org/D72158