[PATCH] D72429: [mlir] Change the syntax of AffineMapAttr and IntegerSetAttr to avoid conflicts with function types.

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 16:44:28 PST 2020


bondhugula added a comment.



In D72429#1811545 <https://reviews.llvm.org/D72429#1811545>, @ftynse wrote:

>


I don't think repetition is a big problem, we are doing an IR after all, and we repeat types for all uses of a value, for example. If it proves to be

The type is printed for each use because one'd like to know about the value used by looking at the op locally and without having to search for its definition -- the latter would be a readability killer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72429/new/

https://reviews.llvm.org/D72429





More information about the llvm-commits mailing list