[PATCH] D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Out of curiosity: what's your broader goal with this work? (it'll help understand what's in-scope and out of scope, and better understand the framing when reviewing changes)

> The parser now continues by assuming the larger of the claimed length and parsed length is correct.

This seems like a bit of a stretch to guess at which length is the one that's correct. I don't think there's a solid basis to choose either, and if the wrong one is chosen you could start reading from the middle of other opcodes & things, I would imagine, resulting in many follow-on error messages due to apparently further malformed input?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72155/new/

https://reviews.llvm.org/D72155