[PATCH] D71978: [RISCV] Fix evalutePCRelLo for symbols at the end of a fragment

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 14:47:06 PST 2020


efriedma added a comment.

Instead of returning a symbol difference from evaluatePCRelLo and folding it MCAssembler, can just fold the symbol difference to a constant in evaluatePCRelLo itself? MCExpr::evaluateAsRelocatableImpl does something like that in EvaluateSymbolicAdd.

If we can't do that for some reason, FKF_Target seems reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71978/new/

https://reviews.llvm.org/D71978





More information about the llvm-commits mailing list