[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz marked 2 inline comments as done.
zatrazz added inline comments.


================
Comment at: llvm/test/tools/llvm-ranlib/D-flag.test:13
 # RUN: cp %t-no-index.a %t.a && llvm-ranlib -D %t.a
-# RUN: env TZ=UTC llvm-ar tv %t.a | FileCheck %s --check-prefix=DETERMINISTIC-VALUES
+# RUN: (env TZ=UTC date -d '@0' +%H:%M; env TZ=UTC llvm-ar tv %t.a) | FileCheck %s --check-prefix=DETERMINISTIC-VALUES
 
----------------
kristof.beyls wrote:
> I wonder if 'date' is available on all platforms that LLVM builds on. For example, is it available on Windows (with GnuWin32 installed, as per the requirements listed at https://llvm.org/docs/GettingStartedVS.html)? http://gnuwin32.sourceforge.net/packages.html doesn't seem to list "date" explicitly?
It is provided by coreutils (http://gnuwin32.sourceforge.net/packages/coreutils.htm).


================
Comment at: llvm/test/tools/llvm-ranlib/D-flag.test:23
 # RUN: cp %t-no-index.a %t.a && llvm-ranlib -UUD %t.a
 # RUN: env TZ=UTC llvm-ar tv %t.a | FileCheck %s --check-prefix=DETERMINISTIC-VALUES
 
----------------
arichardson wrote:
> Wouldn't this line also have to change?
It does and I updated the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72449/new/

https://reviews.llvm.org/D72449