[PATCH] D72468: Update the attribution policy to use the 'Author' property of a git commit

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 11:11:17 PST 2020


lebedev.ri added a comment.

SGTM in general



================
Comment at: llvm/docs/DeveloperPolicy.rst:295
 
-* Separate the commit message into title, body and, if you're not the original
-  author, a "Patch by" attribution line (see below).
+* Separate the commit message into title, body.
+
----------------
aaron.ballman wrote:
> title, body -> a title and a body.
Worth explicitly stating that there should be an empty line between the title and the body?
I.e. `Separate the commit message into title and body with an empty line.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72468/new/

https://reviews.llvm.org/D72468





More information about the llvm-commits mailing list