[PATCH] D72400: [MLIR] Add OpenMP dialect with barrier operation
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 9 10:42:47 PST 2020
rriddle added inline comments.
================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.h:2
+//===- OpenMPDialect.h - MLIR Dialect for OpenMP ------------*- C++
+//-*-===//
+//
----------------
Please format this to one line.
================
Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:27
+
+#define GET_OP_CLASSES
+#include "mlir/Dialect/OpenMP/OpenMPOps.cpp.inc"
----------------
This is the only thing that should be wrapped in a 'namespace mlir { namespace omp {} }`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72400/new/
https://reviews.llvm.org/D72400
More information about the llvm-commits
mailing list