[PATCH] D72461: [AIX][XCOFF] Supporting the ReadOnlyWithRel SectionKnd

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 09:17:52 PST 2020


hubert.reinterpretcast added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1873
 
-  if (Kind.isData())
+  if (Kind.isData() || Kind.isReadOnlyWithRel())
     return DataSection;
----------------
Please add a TODO for putting this under option control. The user may want to have read-only data with relocations placed into a read-only section by the compiler. There are linker options, such as `-Wl,-bforceimprw` (which would make sense to use alongside `-fdata-sections`), that support such cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72461/new/

https://reviews.llvm.org/D72461





More information about the llvm-commits mailing list