[PATCH] D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

I think the change is correct, and desirable for the reasons you mentioned previously: we get consistent semantics whether function sections are used or not, and consistent behavior whether we use the integrated assembler or not. There is a chance this patch affects some users negatively despite being correct. Ideally we would commit to at least supporting part of the semantic-interposition option (so the user can opt in to disabling IPO when the callee is runtime replaceable) in the same release we land this fix. If I had the bandwidth to do this I would offer but I don't :(.  Because of that user impact I don't feel confident enough to approve the patch myself, but I have no strong objection against it landing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72197/new/

https://reviews.llvm.org/D72197