[PATCH] D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use.

[Aaron Puchert via Phabricator via llvm-commits]

aaronpuchert added a comment.

In D65661#1615277 <https://reviews.llvm.org/D65661#1615277>, @morehouse wrote:

> Without this patch, any project that wants to use this header needs to add a vendored copy of FDP to their source repository.  With this patch, non-clang will still have to do this, though projects that build with clang will not.


Wasn't @lebedev.ri's point that projects might use multiple compilers? Projects that build with Clang might also build with other compilers. So what you call "non-clang" should probably be "not-exclusively-clang", and the only projects benefiting are those that build only with Clang.

It seems to me as if this header is compiler-independent, so why is it in Clang's builtin include directory (on Linux that's `<prefix>/lib/clang/<version>/include`) as opposed to the system include directory (on Linux, `<prefix>/include`)? The builtin include directory is supposed to contain headers that are "private" to Clang, because they contain non-standard C/C++ that is only guaranteed to be supported by Clang. (Basically stuff that starts with two underscores like builtins.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65661/new/

https://reviews.llvm.org/D65661