[PATCH] D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 237000.
jhenderson edited the summary of this revision.
jhenderson added a parent revision: D72154: [DebugInfo] Make debug line address size mismatch non-fatal to parsing.
jhenderson added a comment.

Added unit test case that would trigger the assertion mentioned in the description. I'm not entirely convinced that this test case is worthwhile, since with the change in how size() is calculated, it really is moot (e.g. I wouldn't have needed it if the size() function had always been the way I'm proposing).

Also, adding the unit test makes this patch now depend on D72154 <https://reviews.llvm.org/D72154> (well, not strictly - I could implement without the dependency, but the two overlap in my branch).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72337/new/

https://reviews.llvm.org/D72337

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
  llvm/include/llvm/Support/DataExtractor.h
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
  llvm/unittests/Support/DataExtractorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72337.237000.patch
Type: text/x-patch
Size: 4948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200109/d0ce97b8/attachment.bin>